Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pure_pursuit): rework parameters #8196

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor(pure_pursuit): rework parameters #8196

wants to merge 6 commits into from
+121 −0

Conversation

batuhanbeytekin
Copy link
Member

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371

Tests performed

Package built and launch locally.

Effects on system behavior

More reliable and faster parameter configuration file creation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@batuhanbeytekin batuhanbeytekin added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) DevOps Dojo: ROS Node Conf Related to Open AD Kit WG run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jul 25, 2024
@batuhanbeytekin batuhanbeytekin self-assigned this Jul 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jul 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Documentation URL: https://autowarefoundation.github.io/autoware_universe/pr-8196/
Modified URLs:

@codecov Codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.09%. Comparing base (a20e0e6) to head (fb9d549).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8196      +/-   ##
==========================================
- Coverage   24.92%   24.09%   -0.84%     
==========================================
  Files        1323     1386      +63     
  Lines      103221   102732     -489     
  Branches    39186    38793     -393     
==========================================
- Hits        25726    24751     -975     
- Misses      75050    75509     +459     
- Partials     2445     2472      +27
Flag Coverage Δ *Carryforward flag
differential 39.15% <ø> (?)
total 23.75% <ø> (-1.17%) ⬇️ Carriedforward from e9500ba

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

batuhanbeytekin and others added 2 commits August 12, 2024 19:55
@batuhanbeytekin @oguzkaganozt
refactor(pure_pursuit): rework parameters
d133266 
Signed-off-by: batuhanbeytekin <batuhanbeytekin@gmail.com>
@pre-commit-ci @oguzkaganozt
style(pre-commit): autofix
225a130
@oguzkaganozt oguzkaganozt force-pushed the refactor/pure_pursuit branch from c14c84c to 225a130 Compare August 12, 2024 16:55
@mitsudome-r
Copy link
Member

I was testing this locally by running the local launch file, but there seems to be a issue with package names.
They are fixed in this PR.
https://github.com/autowarefoundation/autoware.universe/pull/8687/files

@batuhanbeytekin
Copy link
Member Author

I was testing this locally by running the local launch file, but there seems to be a issue with package names. They are fixed in this PR. https://github.com/autowarefoundation/autoware.universe/pull/8687/files

Thank you for your feedback

@mitsudome-r mitsudome-r enabled auto-merge (squash) September 5, 2024 14:08
@stale Stale
Copy link

stale bot commented Nov 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Nov 4, 2024
@mitsudome-r
Copy link
Member

@mitsudome-r To test the launch file again.

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jan 14, 2025
@stale Stale
Copy link

stale bot commented Mar 15, 2025

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Mar 15, 2025
mitsudome-r
mitsudome-r approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a test locally and confirmed that the launch file in pure_pursuit works correctly.

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsudome-r mitsudome-r mitsudome-r approved these changes

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@batuhanbeytekin batuhanbeytekin

Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) DevOps Dojo: ROS Node Conf Related to Open AD Kit WG run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@batuhanbeytekin @mitsudome-r